Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add abilty to edit memories #3116

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

Peter-De-Ath
Copy link
Contributor

@Peter-De-Ath Peter-De-Ath commented Jun 13, 2024

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests for validating the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Allow updating of memories

Added

Add the ability to update a memory via the API using a PATCH request.
Add ability to update a memory in the UI.

Changed

Update memories list heading to "Last Modified" from "Created At"
Updated timestamp to include the hours mins and seconds

Additional Information

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]
    image
    image

backend/apps/webui/routers/memories.py Outdated Show resolved Hide resolved
import { toast } from 'svelte-sonner';

const dispatch = createEventDispatcher();

export let show;
export let memory = {};

let showUpdateBtn = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the frontend part!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Sir! 👍
Appreciate that, first time working with svelte

@tjbck
Copy link
Contributor

tjbck commented Jun 15, 2024

I'll merge this first then refactor, LGTM, Thanks!

@tjbck tjbck merged commit a6ee741 into open-webui:dev Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants