feat: match the theme color of status bar in light/dark mode #3358
Comments
|
Just pushed a commit to dev, let me know if that did anything for you! |
|
Thanks for your quick response! Now it can change color based on light/dark mode. One nitpick is that the white/black color and the status bar don't exactly match the white/black of the app theme, it would be better if they could match! |
|
The updated implementation delegates setting the colour to the device, further improvement won't be possible unless we overhaul the manifest.json code entirely. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Now the PWA
theme_coloris hard-coded to#343541(according to my search), which makes the status bar doesn't looks like a native app in light mode.Describe the solution you'd like
I'm not sure but there should be a method to match the color.
Describe alternatives you've considered
N/A
Additional context
See also:
https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/How_to/Customize_your_app_colors
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme
elk-zone/elk#941
cheeaun/phanpy#231
The text was updated successfully, but these errors were encountered: