Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update yaml.is_valid for changes in OPA 0.43.0 #260

Open
srenatus opened this issue Sep 2, 2022 · 1 comment · May be fixed by #282
Open

update yaml.is_valid for changes in OPA 0.43.0 #260

srenatus opened this issue Sep 2, 2022 · 1 comment · May be fixed by #282

Comments

@srenatus
Copy link
Contributor

srenatus commented Sep 2, 2022

It's now expected to be false instead of undefined.

When fixing this, we should be able to bump the version of OPA used in CI to 0.43.0 (or 0.44.0 when it's released).
@srenatus srenatus changed the title update is_valid for changes in OPA 0.43.0 update yaml.is_valid for changes in OPA 0.43.0 Sep 2, 2022
@srenatus srenatus linked a pull request Oct 13, 2022 that will close this issue
Draft
srenatus added a commit to srenatus/npm-opa-wasm that referenced this issue Oct 13, 2022
@srenatus
builtins: update json.is_valid and yaml.is_valid for OPA v0.44.0
0239960 
We're pulling the testcases only from 0.45.0 now; and use setup-opa for getting
the binary that's used to generate the wasm module of the correct ABI version.

Fixes open-policy-agent#260.

Signed-off-by: Stephan Renatus <[email protected]>
srenatus added a commit to srenatus/npm-opa-wasm that referenced this issue Oct 13, 2022
@srenatus
builtins: update json.is_valid and yaml.is_valid for OPA v0.44.0
926fc72 
We're pulling the testcases only from 0.45.0 now; and use setup-opa for getting
the binary that's used to generate the wasm module of the correct ABI version.

Fixes open-policy-agent#260.

Signed-off-by: Stephan Renatus <[email protected]>
@srenatus
Copy link
Contributor Author

There are also new errors when running against OPA v0.60.0. See here while the logs are still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

builtins: update json.is_valid and yaml.is_valid for OPA v0.44.0 srenatus/npm-opa-wasm
1 participant
@srenatus