Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoiding hard coding in dataset file #254

Closed
nghiahuynh-ai opened this issue Jul 26, 2024 · 1 comment
Closed

Avoiding hard coding in dataset file #254

nghiahuynh-ai opened this issue Jul 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nghiahuynh-ai
Copy link

Untitled
@nghiahuynh-ai nghiahuynh-ai added the bug Something isn't working label Jul 26, 2024
@jiaqili3
Copy link
Collaborator

@nghiahuynh-ai Thanks for the advice, it's surely a good practice to avoid hard coding configurations. In this specific case, limiting the duration of training samples there for libritts is understandable, and there's a printout for this. I'll add a pr to improve this.

@jiaqili3 jiaqili3 changed the title [BUG]: Please stop hard coding! Avoiding hard coding in dataset file Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nghiahuynh-ai @jiaqili3