Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Uid format in preprocessors/popbutfy.py may be incorrect #196

Open
Nugine opened this issue May 4, 2024 · 1 comment
Open

[BUG]: Uid format in preprocessors/popbutfy.py may be incorrect #196

Nugine opened this issue May 4, 2024 · 1 comment
Assignees
@Adorable-Qin
Labels
bug Something isn't working

Comments

@Nugine
Copy link

Nugine commented May 4, 2024

Describe the bug

Found by linter scanning

$ ruff check --select F523
preprocessors/popbutfy.py:104:28: F523 [*] `.format` call has unused arguments at position(s): 2
Found 1 error.
[*] 1 fixable with the `--fix` option.

Amphion/preprocessors/popbutfy.py

Line 104 in d335514

"Uid": "{}#{}#".format(singer, chosen_song, chosen_uid),

Amphion/preprocessors/popbutfy.py

Lines 100 to 105 in d335514

res = {
"Dataset": "popbutfy",
"Singer": singer,
"Song": chosen_song,
"Uid": "{}#{}#".format(singer, chosen_song, chosen_uid),
}

@Nugine Nugine added the bug Something isn't working label May 4, 2024
@RMSnow
Copy link
Collaborator

RMSnow commented May 4, 2024

Hi @Nugine, thanks a lot! We will patch it soon (cc @Adorable-Qin )

@Nugine Nugine mentioned this issue May 7, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adorable-Qin Adorable-Qin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RMSnow @Nugine @Adorable-Qin