Context

Addressing review comments

The root block creation bootstrap command uses information from both internal nodes and partner nodes to create the root block. Internal node information is retrieved locally, while partner node information is obtained from the identity table state.

During a spork, data from some partners (Dapper nodes) are treated as internal nodes for root block creation. This results in an overlap between internal and partner nodes, causing incorrect calculations for the percentage of partner collection nodes and leading to validation failures.

We addressed this by identifying the overlap between internal and partner nodes, treating the overlapping nodes as internal nodes.

However, this approach automatically accepts the overlap without review or validation, introducing potential risks.

A better solution would be to specify the list of internal partners in a file, using it to validate the overlap between internal and partner nodes. Overlaps should only be accepted if they match the specified list, with exceptions thrown for mismatches.

This approach not only provides a clearer definition of internal partners in the code but also helps prevent errors.