Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] Removing obsolete settings #2916

Closed
janezpodhostnik opened this issue Aug 3, 2022 · 2 comments
Closed

[FVM] Removing obsolete settings #2916

janezpodhostnik opened this issue Aug 3, 2022 · 2 comments
Assignees
Labels
Execution Cadence Execution Team Stale Label used when marking an issue stale.

Comments

@janezpodhostnik
Copy link
Contributor

Problem Definition

As the FVM matures, some settings are no longer needed. Continuing support for those settings increases the complexity of the code and the amount of code paths that need to be tested.

Proposed Solution

  • TransactionFeesEnabled should be removed. If a situation requires the transaction fees to be disabled, they should be set to 0 instead.
  • MaxNumOfTxRetries is not used and should be removed.
  • restrictedAccountCreationEnabled will not be used anymore.
  • RestrictContractDeployment and RestrictContractRemoval and MemoryLimit are FVM variables and constants in the state, where the state constants take precedence. They should move to the state completely and the FVM settings removed. This can be done after canary, testnet and mainnet have the settings set in the state.
  • LimitAccountStorage should be always enabled, and the setting removed. (could cause problems in tests)
  • AllowContextOverrideByExecutionState was a temp workaround to allow the system transaction to run with more resources. An alternate solution should be found.

Some of these also require core contract changes (cleanups).

Definition of Done

  • Remove the mentioned settings
  • Check for any other FVM settings that can be removed
@janezpodhostnik janezpodhostnik added the Execution Cadence Execution Team label Aug 3, 2022
@janezpodhostnik janezpodhostnik self-assigned this Aug 3, 2022
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Sep 16, 2024
@janezpodhostnik janezpodhostnik removed the Stale Label used when marking an issue stale. label Sep 25, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Dec 25, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Stale Label used when marking an issue stale.
Projects
None yet
Development

No branches or pull requests

1 participant