Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in the Memory Format Diagram of Blocked Layout #1643

Open
topsy404 opened this issue May 6, 2023 · 1 comment
Open

Typos in the Memory Format Diagram of Blocked Layout #1643

topsy404 opened this issue May 6, 2023 · 1 comment
Labels
documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc

Comments

@topsy404
Copy link

topsy404 commented May 6, 2023

Summary

There are two typos in the memory format diagram.

URLs

Blocked Layout Docs
Diagram Link

Additional details

  1. Since the sub-block size is 8, the last plane of the first sub-block should be the plane with index 7 instead of the plane with index 8.
  2. Furthermore, the physical data layout in the diagram is incorrect. The [x:3] should switch from [139 159] to [160 180] instead of [159 179] to [180 200].

I think the correct version should be the following:

correct_diagram

@topsy404 topsy404 added the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label May 6, 2023
@mgouicem
Copy link
Contributor

mgouicem commented Jun 6, 2023

Thanks for the catch. Indeed you are correct. We will fix this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
Projects
None yet
Development

No branches or pull requests

2 participants