Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.5.0 build fails with libtorrent 1.2.2 #8

Open
lgbaldoni opened this issue Dec 4, 2019 · 8 comments
Open

1.5.0 build fails with libtorrent 1.2.2 #8

lgbaldoni opened this issue Dec 4, 2019 · 8 comments

Comments

@lgbaldoni
Copy link

Building MotionBox Sky on openSUSE Tumbleweed, see log.
@3unjee
Copy link
Member

3unjee commented Dec 16, 2019

Thanks @luigino. I'll take a closer look.

@3unjee
Copy link
Member

3unjee commented Dec 16, 2019

It builds fine on Windows 10, Boost 1.71.0 and libtorrent 1.2.2.

Are you sure you are linking against the proper libtorrent library ?

@lgbaldoni
Copy link
Author

I should add the problem is solved by this patch:

Index: MotionBox-1.5.0/Sky-1.5.0/src/SkTorrent/SkTorrent.pro
===================================================================
--- MotionBox-1.5.0.orig/Sky-1.5.0/src/SkTorrent/SkTorrent.pro
    MotionBox-1.5.0/Sky-1.5.0/src/SkTorrent/SkTorrent.pro
@@ -33,8  33,6 @@ contains(QT_MAJOR_VERSION, 4) {
     DEFINES  = QT_LATEST
 }
 
-QMAKE_CXXFLAGS  = -std=c  11
-
 unix:QMAKE_LFLAGS  = "-Wl,-rpath,'\$$ORIGIN'"
 
 include(src/controllers/controllers.pri)

@3unjee
Copy link
Member

3unjee commented Dec 23, 2019

Oh, that's weird, libtorrent 1.2.x is supposed to compile with C 11 support.

@lgbaldoni
Copy link
Author

Problem still extant in 1.6.0, also it has propagated to MotionBox itself.

@3unjee
Copy link
Member

3unjee commented Jan 16, 2020 •
edited
Loading

Could you try the following:

greaterThan(QT_MAJOR_VERSION, 4) {    
    CONFIG  = c  11
} else {
    QMAKE_CXXFLAGS  = -std=c  11
}

@lgbaldoni
Copy link
Author

If this is what you mean, it makes no difference:

Index: Sky-1.6.0/src/SkTorrent/SkTorrent.pro
===================================================================
--- Sky-1.6.0/src/SkTorrent/SkTorrent.pro
    Sky-1.6.0/src/SkTorrent/SkTorrent.pro
@@ -33,7  33,11 @@ contains(QT_MAJOR_VERSION, 4) {
     DEFINES  = QT_LATEST
 }
 
-QMAKE_CXXFLAGS  = -std=c  11
 greaterThan(QT_MAJOR_VERSION, 4) {
     CONFIG  = c  11
 } else {
     QMAKE_CXXFLAGS  = -std=c  11
 }
 
 unix:QMAKE_LFLAGS  = "-Wl,-rpath,'\$$ORIGIN'"

@3unjee
Copy link
Member

3unjee commented Jan 17, 2020

Oh, I'm not sure what happens here. I would have to test directly on openSUSE.

From my understanding enabling C 11 should not compromise libtorrent builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgbaldoni @3unjee