Skip to content

Commit

Permalink
[MNG-8084] Change six remaining imports of ModelVersionParser. (apa…
Browse files Browse the repository at this point in the history
…che#1527)

This commit aims to complete d075fe7, which moved `ModelVersionParser`
interface from the `org.apache.maven.model.version` package to `org.apache.maven.api.services.model`.
Completing this change is necessary for building `maven-plugin-tools` or `maven-plugin-testing`.

This commit deletes the old interface for making sure that there is no accidental use.
The old and new interfaces were identical except for the package names and the imports.
As a result of this change, the following implementation classes are identical except
for package names and imports:

* `maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultModelVersionParser.java`
* `maven-api-impl/src/main/java/org/apache/maven/internal/impl/DefaultModelVersionParser.java`
  • Loading branch information
desruisseaux authored May 21, 2024
1 parent c87a4b5 commit 39696f2
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 76 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 48,7 @@
import org.apache.maven.api.model.Exclusion;
import org.apache.maven.api.model.InputSource;
import org.apache.maven.api.services.VersionParserException;
import org.apache.maven.api.services.model.ModelVersionParser;
import org.apache.maven.building.Source;
import org.apache.maven.model.Activation;
import org.apache.maven.model.Build;
Expand Down Expand Up @@ -89,7 90,6 @@
import org.apache.maven.model.v4.MavenTransformer;
import org.apache.maven.model.validation.DefaultModelValidator;
import org.apache.maven.model.validation.ModelValidator;
import org.apache.maven.model.version.ModelVersionParser;
import org.codehaus.plexus.interpolation.InterpolationException;
import org.codehaus.plexus.interpolation.Interpolator;
import org.codehaus.plexus.interpolation.MapBasedValueSource;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 23,7 @@
import org.apache.maven.api.Version;
import org.apache.maven.api.VersionConstraint;
import org.apache.maven.api.VersionRange;
import org.apache.maven.api.services.model.ModelVersionParser;
import org.apache.maven.api.spi.ModelParser;
import org.apache.maven.model.Model;
import org.apache.maven.model.composition.DefaultDependencyManagementImporter;
Expand Down Expand Up @@ -74,7 75,6 @@
import org.apache.maven.model.superpom.SuperPomProvider;
import org.apache.maven.model.validation.DefaultModelValidator;
import org.apache.maven.model.validation.ModelValidator;
import org.apache.maven.model.version.ModelVersionParser;

import static java.util.Objects.requireNonNull;

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -28,7 28,7 @@
import org.apache.maven.api.VersionConstraint;
import org.apache.maven.api.VersionRange;
import org.apache.maven.api.services.VersionParserException;
import org.apache.maven.model.version.ModelVersionParser;
import org.apache.maven.api.services.model.ModelVersionParser;
import org.eclipse.aether.version.InvalidVersionSpecificationException;
import org.eclipse.aether.version.VersionScheme;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 20,7 @@

import org.apache.maven.api.VersionConstraint;
import org.apache.maven.api.services.VersionParserException;
import org.apache.maven.model.version.ModelVersionParser;
import org.apache.maven.api.services.model.ModelVersionParser;
import org.eclipse.aether.util.version.GenericVersionScheme;
import org.junit.jupiter.api.Test;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 21,7 @@
import org.apache.maven.api.Version;
import org.apache.maven.api.VersionRange;
import org.apache.maven.api.services.VersionParserException;
import org.apache.maven.model.version.ModelVersionParser;
import org.apache.maven.api.services.model.ModelVersionParser;
import org.eclipse.aether.util.version.GenericVersionScheme;
import org.junit.jupiter.api.Test;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 26,7 @@
import java.util.stream.Stream;

import org.apache.maven.api.Version;
import org.apache.maven.model.version.ModelVersionParser;
import org.apache.maven.api.services.model.ModelVersionParser;
import org.eclipse.aether.util.version.GenericVersionScheme;
import org.junit.jupiter.api.Test;

Expand Down

0 comments on commit 39696f2

Please sign in to comment.