Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root shell in /etc/passwd hosed by oh-my-zsh installer #130

Closed
jpwenzel opened this issue Nov 7, 2010 · 4 comments
Closed

root shell in /etc/passwd hosed by oh-my-zsh installer #130

jpwenzel opened this issue Nov 7, 2010 · 4 comments

Comments

@jpwenzel
Copy link

jpwenzel commented Nov 7, 2010

The root shell on one of my machines got hosed after I used the oh-my-zsh installer:

% grep root /etc/passwd
root:x:0:0:root:/root:/usr/bin/env zsh

Now, when I try to su to the root user, I get this:

% su -
Cannot execute /usr/bin/env zsh: No such file or directory

No bueno… :(
@gwjo
Copy link
Contributor

gwjo commented Nov 7, 2010

Setting the shell to this isn"t a good idea on any system - even when it does work. When you set the shell to something that isn"t listed in /etc/shells/ then you are likely to break certain logins, such as FTP.

Some setups won"t even allow non superusers to change the shell to something not in /etc/shells

@jpwenzel
Copy link
Author

jpwenzel commented Nov 8, 2010

I wish Debian would have forbid me to do so... :) Eventually, I was able to recover that particular entry in /etc/passwd.

I"d prefer an option (disabled by default) for setting the shell during the execution of the installer script.

@gwjo
Copy link
Contributor

gwjo commented Apr 27, 2011

This is fixed by the merging of pull request #287 and should be closed

@sorin-ionescu sorin-ionescu mentioned this issue Jan 26, 2012
Closed
@robbyrussell
Copy link
Member

Closing per the advice of #2568.

nguymin4 pushed a commit to nguymin4/oh-my-zsh that referenced this issue Jul 26, 2024
@mafredri
Merge pull request ohmyzsh#130 from zmwangx/rename-variables-for-read…
a099059 
…ability

Rename two internal variables for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robbyrussell @jpwenzel @gwjo