ConnectionString javadoc #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incubos
requested changes
Jun 25, 2024
src/one/nio/pool/SocketPool.java
Outdated
| @@ -33,7 33,7 @@ public class SocketPool extends Pool<Socket> implements SocketPoolMXBean { | |||
|
|
|||
| public SocketPool(ConnectionString conn) { | |||
| super(conn.getIntParam("clientMinPoolSize", 0) > 0 ? 1 : 0, | |||
| conn.getIntParam("clientMaxPoolSize", 10), | |||
| conn.getIntParam("clientMaxPoolSize", 5000), | |||
There was a problem hiding this comment.
Altering defaults is extremely hazardous in such projects. Please, revert this change.
Comment on lines
38
to
58
| * keepalive | default true | ||
| * bufferSize | default 8000 | ||
| * timeout | default 3000 | ||
| * readTimeout | default 3000 | ||
| * connectTimeout | default 1000 | ||
| * fifo | default false | ||
| * jmx | default false | ||
| * clientMinPoolSize | default 0 | ||
| * clientMaxPoolSize | default 5000 | ||
| * schedulingPolicy | default OTHER | @see SchedulingPolicy | ||
| * tos | default 0 | @see Socket Type of Service | ||
| * recvBuf | default 0 | ||
| * sendBuf | default 0 | ||
| * backlog | default 128 | ||
| * selectors | default 0 | ||
| * minWorkers | default 0 | ||
| * maxWorkers | default 0 | ||
| * queueTime | default 0 | ||
| * closeSessions | default false | ||
| * threadPriority | default Thread.NORM_PRIORITY | ||
| * proxy |
There was a problem hiding this comment.
What do you think about adding monospaced formatting?
|
@incubos not sure what "monospaced formatting" is. Could you please provide some example with this? Can't find any in google. Thanks! |
Here is some example, otherwise the formatting will be unaligned. |
|
@incubos done |
incubos
requested changes
Jul 1, 2024
|
@incubos fixed |
incubos
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also I have changed param clientMaxPoolSize from 10 to 5000 because http client from one-nio usually used for high-load system where we need a lot of connections and value 5000 more suitable for such cases. And because of poor docs it's not obvious how to increase this value. I bet a lot of developers like me starting to use http client on production and realised that the performance is terrible, although all integration tests were normal, since 10 sockets per address are enough for tests.