Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compl deemed dangerous #66

Open
Chris00 opened this issue Jun 17, 2015 · 3 comments
Open

compl deemed dangerous #66

Chris00 opened this issue Jun 17, 2015 · 3 comments

Comments

@Chris00
Copy link
Member

Chris00 commented Jun 17, 2015

The interface says

val compl : t list -> t
(** Complement of union *)

but compl cannot be applied to any list of regexpes... and, more problematically, it fails at runtime! I think that this ought to be fixed—maybe adding some phantom type to t or changing compl arguments.
@Drup
Copy link
Collaborator

Drup commented Jul 8, 2015

A phantom type is probably out of the question (for compat reasons). I'm not sure what other kind of changes could be applied.

@rgrinberg
Copy link
Member

@Drup Why is it out of question? You couldn't maintain compat. with aliases?

Also, providing a new, safe API sounds plausible as well (we've deprecated other stuff before)

@Drup
Copy link
Collaborator

Drup commented Dec 26, 2015

@rgrinberg I will believe it when I see it, but I don't think it would work very well. Also, I doubt it would be such a good solution. I would prefer to extend the handling of compl to other constructs, but it's much more difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rgrinberg @Drup @Chris00