Revert 0.5.5 regression #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts the ordering that was changed in: oauth-xx@d74b767#diff-7539411a25dc370ad4ed8baed9d33ad853f07cadcfcc8c566494ecc438f5bd16 Once we know we are in an infinite redirect, we should fail immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing the changes between 0.5.4 -> 0.5.5, I noticed that the error handling had been shifted later in the method unnecessarily.
This commit reverts the ordering that was changed in:
d74b767#diff-7539411a25dc370ad4ed8baed9d33ad853f07cadcfcc8c566494ecc438f5bd16
Once we know we are in an infinite redirect, we should fail immediately. This keeps us from creating an unnecessary HTTP object and any side-effects from creating one. (e.g. additional allocations, URI parsing errors, etc.)
I've run the specs against ruby 2.7.3 with 0 failures.
Note: I rarely use Minitest so feedback welcome.