-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename TRAVIS_CI environment variable #279
Labels
tests
Issues related to automated tests
Comments
I think we can rename TRAVIS_CI to GITHUB_CI. All the OVIRT_CI checks are not relevant and likely can be removed. Some of the TRAVIS_CI marks are also not relevant and can be removed, but not all. Some tests cannot run in containers so we cannot run them on github. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The tests use
TRAVIS_CI
environment variable (e.g., in thebroken_on_ci
fixture) to determine ifwe run in a CI, for tests that are expected to fail only in the pipeline run. Places where is used:
However, we do not run in Travis anymore, which makes the variable misleading.
We should rename the variable to avoid using Travis, to something such as
RUN_ON_CI
orOVIRT_CI
, which ismore generic.
The text was updated successfully, but these errors were encountered: