Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_files and find_files don"t allow spaces anymore #3364

Closed
Laurensdc opened this issue Nov 15, 2024 · 5 comments
Closed

git_files and find_files don"t allow spaces anymore #3364

Laurensdc opened this issue Nov 15, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Laurensdc
Copy link

Laurensdc commented Nov 15, 2024

Description

  • For a directory structure of /saving-action/nested/folder/error.ts I used to find that file by searching saving-action error
  • Now, adding a space between my words no longer fuzzy finds for a match with both of those words
Screen.Recording.2024-11-15.at.08.07.26.mp4

Neovim version

❯ nvim --version
NVIM v0.10.2
Build type: Release
LuaJIT 2.1.1727870382
Run "nvim -V1 -v" for more info

Operating system and version

macOS 14.7

Telescope version / branch / rev

0.1.8

checkhealth telescope

==============================================================================
telescope: require("telescope.health").check()

Checking for required plugins ~
- OK plenary installed.
- OK nvim-treesitter installed.

Checking external dependencies ~
- OK rg: found ripgrep 14.1.1
- OK fd: found fd 10.2.0

===== Installed extensions ===== ~

Telescope Extension: `gitmoji` ~
- No healthcheck provided

Steps to reproduce

  • Open either picker: git_files or find_files
  • Search for a term with 2 words: some_directory [space] the_filename
  • There are no matches

Expected behavior

  • It fuzzy finds and matches the entries containing both of the words I entered

Actual behavior

  • It shows no entries

Minimal config

I don"t believe my config changed when this started happening.
If necessary I can try and add this, let me know.

@Laurensdc Laurensdc added the bug Something isn't working label Nov 15, 2024
@Laurensdc
Copy link
Author

I had a secondary machine where I introduced this bug through doing a :Lazy update.

These are the packages and versions that were bumped, introducing the bug:
Laurensdc/dotfiles@9411056

@ArnauLlamas
Copy link

Hey @Laurensdc

I had the same issue and turns out that during a refactor of my config I accidentally deleted the loading of the fzf extension call, you should add require("telescope").load_extension("fzf) somewhere after the Telescope plugin setup; more details on how to load it correctly here.

Just for your info, I think that this "issue" is actually the default behavior of the plugin and the white space behavior works only after loading the fzf native extension correctly.

@Laurensdc
Copy link
Author

Wow, exactly, the require("telescope").load_extension("fzf") was missing from my config.
Thank you so much!

@theherk
Copy link

theherk commented Dec 19, 2024

What the hell? I guess I"m crazy. I could have sworn that was working before, but yeah this was the solution.

I added

  {
    "nvim-telescope/telescope-fzf-native.nvim",
    build = "make",
    dependencies = { "nvim-telescope/telescope.nvim" },
  },

and

    config = function(_, opts)
      require("telescope").setup(opts)
      require("telescope").load_extension("fzf")
    end,

@Laurensdc
Copy link
Author

I"ll add my solution as well: Laurensdc/dotfiles@263f879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants