Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unable to configure server integration using inline options #3020

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: unable to configure server integration using inline options #3020

merged 1 commit into from
Jul 10, 2024
48 −7

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Server integration did not work when using inline options 😅 Thanks to the investigation here #2721 (comment) this was an easy fix!

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede requested a review from kazupon July 9, 2024 19:35
@BobbieGoede BobbieGoede self-assigned this Jul 9, 2024
@BobbieGoede BobbieGoede mentioned this pull request Jul 9, 2024
Closed
kazupon
kazupon approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Thanks!

@kazupon kazupon merged commit 6c51eb4 into nuxt-modules:main Jul 10, 2024
7 checks passed
BobbieGoede added a commit to BobbieGoede/i18n that referenced this pull request Jul 26, 2024
@BobbieGoede
fix: unable to configure server integration using inline options (nux…
856ba4f 
…t-modules#3020)
@renovate renovate bot mentioned this pull request Sep 14, 2024
Merged
1 task
@KTrain5169 KTrain5169 mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees

@BobbieGoede BobbieGoede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobbieGoede @kazupon