fix(schema): fix srcDir being overriden by default value #28249

huang-julien · 2024-07-21T21:25:32Z

this PR fix schema to stop overridinguser value for srcDir by the default value

stackblitz · 2024-07-21T21:25:35Z

Run & review this pull request in StackBlitz Codeflow.

packages/schema/src/config/common.ts

Co-authored-by: Daniel Roe <[email protected]>

fix(schema): fix srcDir being overriden by default value

a41ea7a

huang-julien requested a review from danielroe as a code owner July 21, 2024 21:25

github-actions bot added 3.x bug labels Jul 21, 2024

huang-julien marked this pull request as draft July 21, 2024 21:25

test: add regression test

0539cf0

huang-julien marked this pull request as ready for review July 21, 2024 22:06

danielroe reviewed Jul 21, 2024

View reviewed changes

packages/schema/src/config/common.ts Outdated Show resolved Hide resolved

danielroe reviewed Jul 21, 2024

View reviewed changes

packages/schema/src/config/common.ts Outdated Show resolved Hide resolved

Update packages/schema/src/config/common.ts

5d7e296

Co-authored-by: Daniel Roe <[email protected]>

danielroe approved these changes Jul 23, 2024

View reviewed changes

danielroe merged commit ed54884 into main Jul 23, 2024
38 checks passed

danielroe deleted the fix/server_dir branch July 23, 2024 08:31

github-actions bot mentioned this pull request Jul 23, 2024

v4.0.0 #27716

Draft

danielroe pushed a commit that referenced this pull request Jul 23, 2024

fix(schema): do not override user serverDir (#28249)

9ac4da0

github-actions bot mentioned this pull request Jul 23, 2024

v3.12.5 #28217

Closed

5 tasks

github-actions bot mentioned this pull request Aug 8, 2024

v3.13.0 #28466

Merged

5 tasks

Provide feedback