Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): handle external links to named route objects #27829

Merged
merged 21 commits into from
Jun 26, 2024
Merged

Conversation

rexhent
Copy link
Contributor

@rexhent rexhent commented Jun 26, 2024

🔗 Linked issue

Revert changes to nuxt-link.ts to fix #27817

📚 Description

Revert nuxt-link.ts to 3.12.1 version, where #27817 is not present.

Copy link

stackblitz bot commented Jun 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jun 26, 2024
Copy link
Contributor Author

@rexhent rexhent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This obviously isn't a solution, it just reverts it to where the issue was not present.

@rexhent rexhent changed the title Revert changes to nuxt-link.ts to fix #27817 fix: revert changes to nuxt-link.ts to fix #27817 Jun 26, 2024
@danielroe danielroe changed the title fix: revert changes to nuxt-link.ts to fix #27817 fix(nuxt): handle external links to named route objects Jun 26, 2024
@danielroe danielroe merged commit 07e1818 into nuxt:main Jun 26, 2024
38 checks passed
@danielroe
Copy link
Member

cc: @manniL if you have any better suggestions

@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuxtLink not rendering href attribute with external prop set to true
2 participants