feat(webpack): migrate to memfs
#27652
Merged
93
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #27652 /- ##
==========================================
- Coverage 66.23% 65.86% -0.38%
==========================================
Files 93 93
Lines 4123 4139 16
Branches 1170 1172 2
==========================================
- Hits 2731 2726 -5
- Misses 1126 1145 19
- Partials 266 268 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielroe
changed the title
memfsmemfs
pi0
reviewed
Jun 17, 2024
pi0
approved these changes
Jun 17, 2024
Closed
This was referenced Jul 19, 2024
This was referenced Jul 27, 2024
This was referenced Jul 27, 2024
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #26435
related #21804, #20564
📚 Description
This migrates from 'memory-fs' to 'memfs'.
This is necessary because of a breaking change with 'webpack-dev-middleware' in 5.0.0 . But sticking to 5.0.0 would mean that we would have a known security vulnerability with path traversal: GHSA-wr3j-pwj9-hqq6.