fix(kit): avoid falling back to normalized path for loadNuxtModuleInstance
#27507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
approved these changes
Jun 10, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while investigating #27479
When installing nuxt modules, we use
kit.resolvePathutility first to resolve aliases, etc.If they cannot be resolved for any reason (this way happening in unit tests silently), the util returns the normalized value (which is
${cwd}/path).Returned value can be something like
/source/to/nuxt/@nuxt/telemetrywhich is obviously invalid and was being passed to theimport()which was obviously always failing even when the module is a valid ESM module and then fallback tojiti(viakit.requireModule)Jiti's ESM resolver (bundled mlly) was somehow (yet i don't know how) fixing this situation but with latest bundled ESM resolve algorithm, it won't be effective and revealed this..