Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): handle more edge cases with external/custom links #27487

Merged
merged 11 commits into from
Jun 13, 2024
Merged

fix(nuxt): handle more edge cases with external/custom links #27487

merged 11 commits into from
Jun 13, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 7, 2024 •
edited
Loading

🔗 Linked issue

#25532
resolves #27312

📚 Description

This handles a few things:

  1. improves types for defineNuxtLink so it doesn't require specifying activeClass, exactActiveClass, prefetchedClass
  2. handles basic resolution of object syntax routes when external is passed
  3. does not apply trailing slash behaviour to external links

cc: @Mini-ghost

@danielroe danielroe requested a review from manniL June 7, 2024 20:15
@danielroe danielroe self-assigned this Jun 7, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jun 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from harlan-zw June 7, 2024 20:17
@Mini-ghost
Copy link
Contributor

That's great! I manually tested using external links on <NuxtLink> and checked the reactivity of useNuxtLink. Everything seems to be working as expected now.

Thank you!

@danielroe danielroe marked this pull request as ready for review June 13, 2024 15:28
@danielroe danielroe merged commit 95458af into main Jun 13, 2024
60 checks passed
@danielroe danielroe deleted the fix/custom-external-links branch June 13, 2024 15:39
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
@harlan-zw
Copy link
Contributor

Nice 👏

@danielroe danielroe mentioned this pull request Jun 14, 2024
Open
@BalaKadiyala BalaKadiyala mentioned this pull request Jul 10, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Open
@mjbullman mjbullman mentioned this pull request Jul 24, 2024
Open
@kingchappers kingchappers mentioned this pull request Jul 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mini-ghost Mini-ghost Mini-ghost left review comments

@manniL manniL Awaiting requested review from manniL

@harlan-zw harlan-zw Awaiting requested review from harlan-zw

Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning will appear when passing an external link to <NuxtLink>
3 participants
@danielroe @Mini-ghost @harlan-zw