feat(nuxt): register plugin hooks before executing plugins #27449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This seems really good to me ... What makes you think it might be a breaking change? |
|
I might be overly cautious, but theoretically this change might suddenly run hook listeners that didn't run before this change. Since it isn't really documented behavior, it might be ok to do this change anyway |
danielroe
reviewed
Jun 10, 2024
…ster-hooks-before-plugin-execution
…ster-hooks-before-plugin-execution
danielroe
approved these changes
Jun 10, 2024
hendrikheil
deleted the
discussion/27438/register-hooks-before-plugin-execution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
implements #27438
📚 Description
This PR implements the changes described in discussion #27438. It serves as a reference implementation for that discussion, mainly to have a concrete example of the proposed changes.
I'll add tests as the discussion matures.
As this is a breaking change, I think it is best to target this change for 4.xThis now targets 3.12.0