feat(nuxt): reset asyncData to default value when calling clear/clearNuxtData #27295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
changed the title
danielroe
commented
May 21, 2024
danielroe
commented
May 21, 2024
danielroe
commented
May 22, 2024
danielroe
commented
May 22, 2024
| @@ -333,7 339,7 @@ export function useAsyncData< | |||
| return nuxtApp._asyncDataPromises[key]! | |||
| } | |||
|
|
|||
| asyncData.clear = () => clearNuxtDataByKey(nuxtApp, key) | |||
| asyncData.reset = asyncData.clear = () => clearNuxtDataByKey(nuxtApp, key) | |||
There was a problem hiding this comment.
Should we also rename clearNuxtDataByKey to resetNuxtDataByKey?
There was a problem hiding this comment.
Maybe part of a bigger question - should we rename clearNuxtData? In fact I am wondering if it would be better to keep clear/clearNuxtData as reset is a change and in most cases the default value is the empty state of the composable.
danielroe
commented
May 22, 2024
This was referenced May 22, 2024
Merged
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #26269
📚 Description
This changes the default behaviour to reset
data.valueto the default provided by the user rather than unsetting it entirely to null/undefined.It's based on top of the branch for #27294 as it overlaps slightly in scope and mechanism for ensuring this is backwards compatible with
compatibilityVersion: 3.