Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): allows the support of multiple shared runtime context #27068

Merged
merged 14 commits into from
May 8, 2024

Conversation

nicolaspayot
Copy link
Contributor

🔗 Linked issue

First task of #21635

📚 Description

These changes allows the support of multiple shared runtime contexts by namespacing them under a new buildId option, instead of nuxt-app as default. It's one of the first task for multi-app support.

Copy link

stackblitz bot commented May 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nicolaspayot nicolaspayot force-pushed the feat/nuxt/namespace-useNuxtApp branch from e8ef601 to 2089aaf Compare May 6, 2024 08:38
@@ -13,6 13,7 @@ export default defineVitestConfig({
environmentOptions: {
nuxt: {
overrides: {
buildId: 'nuxt-app',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: before release we need to update @nuxt/test-utils to set buildId to nuxt-app in the vitest environment...

Copy link

socket-security bot commented May 7, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Telemetry npm/@nuxt/[email protected]
  • Note: Can be disabled by setting the environment variable NUXT_TELEMETRY_DISABLED=1

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@danielroe danielroe merged commit 1775179 into nuxt:main May 8, 2024
57 of 58 checks passed
@github-actions github-actions bot mentioned this pull request May 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants