Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): don't redirect if initial path has trailing slash #22192

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #22182

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Because nitro will always render routes without trailing slash, this means Nuxt will currently redirect to non-trailing slash option on initial load. This removes that behaviour to allow users to configure nginx/etc as desired.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from manniL July 18, 2023 09:16
@danielroe danielroe self-assigned this Jul 18, 2023
@stackblitz
Copy link

stackblitz bot commented Jul 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit b8a282e into main Jul 18, 2023
28 checks passed
@danielroe danielroe deleted the fix/ignore-trailing-slash-redirects branch July 18, 2023 10:03
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
@rahulkumarsingh73690
Copy link

#22254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants