Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): work around payload extraction issue #22162

Merged
merged 5 commits into from
Jul 18, 2023
Merged

fix(nuxt): work around payload extraction issue #22162

merged 5 commits into from
Jul 18, 2023

Conversation

manniL
Copy link
Member

@manniL manniL commented Jul 15, 2023

🔗 Linked issue

Resolves #22068

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Due to changes from #21860, process.env.NUXT_PAYLOAD_EXTRACTION is set "too early" for mentioned changes to come into effect. To resolve it, I've used Nuxt's nitro config to check for the static override. This should be removed in the future (3.8 or so).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@manniL manniL requested a review from danielroe July 15, 2023 23:12
@danielroe danielroe changed the title fix(core): work around payload extraction issue fix(nuxt): work around payload extraction issue Jul 16, 2023
@manniL manniL marked this pull request as draft July 17, 2023 09:14
@danielroe danielroe marked this pull request as ready for review July 18, 2023 10:58
@manniL manniL merged commit 4b6f3e1 into main Jul 18, 2023
28 checks passed
@manniL manniL deleted the manniL-patch-1 branch July 18, 2023 11:31
This was referenced Jul 18, 2023
Merged
Merged
@danielroe danielroe mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nuxt] Cannot load payload /_payload.json
2 participants
@manniL @danielroe