Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add nuxt-vitest and composable unit tests #21884

Merged
merged 3 commits into from
Jul 2, 2023
Merged

test: add nuxt-vitest and composable unit tests #21884

merged 3 commits into from
Jul 2, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

nuxt/test-utils#349

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds nuxt-vitest to the repo and a small test suite of 'runtime unit' tests for composables.

We can expand on this as needed for new features and iterate to fix issues that are discovered in nuxt-vitest.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu July 1, 2023 22:43
@danielroe danielroe self-assigned this Jul 1, 2023
@stackblitz
Copy link

stackblitz bot commented Jul 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

antfu
antfu approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, love it!

@danielroe danielroe merged commit 6a9fbbf into main Jul 2, 2023
@danielroe danielroe deleted the test/nuxt-vitest branch July 2, 2023 08:59
@github-actions github-actions bot mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees

@danielroe danielroe

Labels
3.x chore test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @antfu