Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): expose useNuxtApp to window for convenience #21636

Merged
merged 3 commits into from
Jun 19, 2023
Merged

feat(nuxt): expose useNuxtApp to window for convenience #21636

merged 3 commits into from
Jun 19, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #15587

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This allows access to the nuxtApp on client side through a global window.useNuxtApp which doesn't rely on auto-imports.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 June 19, 2023 13:22
@danielroe danielroe self-assigned this Jun 19, 2023
pi0
pi0 approved these changes Jun 19, 2023
View reviewed changes
packages/nuxt/src/app/nuxt.ts Outdated Show resolved Hide resolved
@danielroe danielroe merged commit 0e575ad into main Jun 19, 2023
22 checks passed
@danielroe danielroe deleted the feat/window-nuxt branch June 19, 2023 16:17
@github-actions github-actions bot mentioned this pull request Jun 19, 2023
Merged
@manniL manniL mentioned this pull request Jan 20, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@atinux atinux atinux approved these changes

Assignees

@danielroe danielroe

Labels
3.x enhancement 🍰 p2-nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow accessing to nuxt instance from window shortcut
3 participants
@danielroe @atinux @pi0