Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): provide clearNuxtState composable #21409

Merged
merged 13 commits into from
Jun 9, 2023
Merged

feat(nuxt): provide clearNuxtState composable #21409

merged 13 commits into from
Jun 9, 2023

Conversation

jongmin4943
Copy link
Contributor

@jongmin4943 jongmin4943 commented Jun 6, 2023 •
edited
Loading

🔗 Linked issue

#21293

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #21293

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@jongmin4943
Copy link
Contributor Author

I wanted to write tests, but I am not an expert at writing test code. I was trying to find test code of clearNuxtData to copy it, but I could not find it. Could you please provide some tips for tests, if needed and possible?

@jongmin4943 jongmin4943 changed the title Feat/clear nuxt state feat(nuxt): Provide clearNuxtState function for useState Jun 6, 2023
@danielroe danielroe changed the title feat(nuxt): Provide clearNuxtState function for useState feat(nuxt): provide clearNuxtState function Jun 8, 2023
@danielroe danielroe added this to the v3.6 milestone Jun 8, 2023
@jongmin4943
Copy link
Contributor Author

Thanks for the review! Should I write docs about this in this PR?

@danielroe
Copy link
Member

Oh, yes please!

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Jun 8, 2023 •
edited
Loading

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview ce73e7f

@danielroe danielroe changed the title feat(nuxt): provide clearNuxtState function feat(nuxt): provide clearNuxtState composable Jun 9, 2023
@danielroe danielroe merged commit 31a1b98 into nuxt:main Jun 9, 2023
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x enhancement 🍰 p2-nice-to-have
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.

Provide clearNuxtState function for useState
2 participants
@jongmin4943 @danielroe