Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): remove duplicate @default jsdoc tag #21010

Merged
merged 6 commits into from
May 22, 2023
Merged

fix(schema): remove duplicate @default jsdoc tag #21010

merged 6 commits into from
May 22, 2023

Conversation

Lehoczky
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

While checking out the new experimental.watcher option because of the recent speed regression on Windows, I noticed that the option's documentation has two @default tags, one of them incorrect:

image

Removing the manually written @default tag in packages/schema/src/config/experimental.ts seems to solve the issue.
The config.d.ts before, and then after the changes in this PR:

image
image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe merged commit 2518cf8 into nuxt:main May 22, 2023
This was referenced May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants