Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor type tests into a separate fixture #21007

Merged
merged 6 commits into from
May 22, 2023
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 22, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds two new type test fixtures and removes type-only content from the basic fixture. This is part of a bigger reworking of the test fixtures to make it easier to understand what's going on.

It also contains a fix for useRoute and useRouter when used without the pages/ integration (which otherwise reverted back to any).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug label May 22, 2023
@danielroe danielroe requested a review from antfu May 22, 2023 14:13
@danielroe danielroe self-assigned this May 22, 2023
@danielroe danielroe marked this pull request as ready for review May 22, 2023 18:42
@danielroe danielroe merged commit fd30cc1 into main May 22, 2023
@danielroe danielroe deleted the test/split-types branch May 22, 2023 19:44
This was referenced May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant