Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update static to isr #20964

Merged
merged 3 commits into from
May 19, 2023
Merged

docs: update static to isr #20964

merged 3 commits into from
May 19, 2023

Conversation

nateemerson
Copy link
Contributor

🔗 Linked issue

#20963

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Update key in descriptions list of "Rendering Modes" documentation page to use isr and match code snippet.

Resolves #20963

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented May 19, 2023 •
edited
Loading

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview 50d7bb1

@nateemerson
Copy link
Contributor Author

@danielroe's suggestions incorporated!

@danielroe danielroe merged commit d270ab4 into nuxt:main May 19, 2023
@danielroe
Copy link
Member

Thank you ❤️

This was referenced May 19, 2023
Merged
Merged
@flexchar
Copy link

flexchar commented Jul 31, 2023 •
edited
Loading

  1. Is it correct to assume that isr/swr provides that same behaviour as static?

I'm having trouble understanding the variety of options. The re-rendering sounds very appealing but the reason for going for Static Site Generation mode is the highest performance. Which seems to be lost when using swr/isr.

  1. Is static mode deprecated? I'm trying to understand your PR logic. It's like documentation for me.

@nateemerson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: "Rendering Modes" change static to isr in description list
3 participants
@nateemerson @danielroe @flexchar