New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template improvement #26561

Closed

Lehoczky opened this issue Mar 29, 2024 · 1 comment · Fixed by #26562

Labels

Contributor

Lehoczky commented Mar 29, 2024

Patak recently posted about improving the PR template of the vite repo and merged the improvements in vitejs/vite#16266.

I agree with these two points in his PR description:

I don't think the "purpose of this pull request" section is useful. ... we already have this information in the PR title as we use conventional commit (fix, feat, docs, chore, etc).

Nobody is completing the "Before submitting the PR" section. The checkboxes doesn't render so it isn't good UX for contributors.

What do you think about changing this in the Nuxt repo as well?

Lehoczky mentioned this issue

chore: improve pr template #26562

Merged

9 tasks

danielroe added the chore label

danielroe closed this as completed in #26562

Contributor Author

Lehoczky commented Mar 29, 2024

@pi0 Let me know if you want to try the new template in unjs repositories as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment