Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doccomments to find functions in EngineState and StateWorkingSet #14750

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

132ikl
Copy link
Contributor

@132ikl 132ikl commented Jan 4, 2025

Description

Adds some doccomments to some of the methods in engine_state.rs and state_working_set.rs. Also grouped together some of the find methods in engine_state.rs, but didn"t do so in state_working_set.rs since they seem to already be grouped according to decl/overlay/module.

Follow-up to #14490.

User-Facing Changes

None

Tests + Formatting

N/A

After Submitting

N/A

Copy link
Collaborator

@WindSoilder WindSoilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! More documents always good

@WindSoilder WindSoilder merged commit 88f4470 into nushell:main Jan 6, 2025
15 checks passed
@github-actions github-actions bot added this to the v0.102.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants