Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Numba to LLVM's NewPassManager #9676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move Numba to LLVM's NewPassManager #9676

wants to merge 2 commits into from

Conversation

yashssh
Copy link
Contributor

@yashssh yashssh commented Jul 30, 2024 •
edited
Loading

numba/llvmlite#1046 made Numba ready to migrate to new pass manager and this change implements that in Numba.

As of now 3 tests are failing:

  • numba/tests/test_debuginfo.py:test_DILocation, To be fixed post Move creation of mpm to optimize_final_module #9670
  • numba/tests/test_llvm_pass_timings.py:test_usage, TODO: Missing functionality
  • numba/tests/test_refop_pruning.py:test_fanout_3, Test need to be updated

I'm not sure what work needs to be done on Cuda side and when I run the tests I see all the cuda tests are skipped.

@yashssh
Copy link
Contributor Author

yashssh commented Jul 30, 2024 •
edited
Loading

Please note this merge request requires llvmlite built with numba/llvmlite#1057 merged for refprune tests to pass.

If the maintainers feel this should be marked draft before 1057 is merged, please feel free to do so, thanks!

@kc611 kc611 requested a review from gmarkall July 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarkall gmarkall Awaiting requested review from gmarkall

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2 - In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yashssh @kc611