Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler error on RTD #9675

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix compiler error on RTD #9675

merged 1 commit into from
Jul 30, 2024

Conversation

sklam
Copy link
Member

@sklam sklam commented Jul 29, 2024 •
edited
Loading

Change summary:

  • make sure we have specify the compiler.
  • use miniconda instead of mambaforge.

The mambaforge problem:

Below is from a failing build, by printing CC/CXX in sysconfig:

SYSCONFIG[CC] gcc -pthread -B /home/docs/checkouts/readthedocs.org/user_builds/numba/conda/9675/compiler_compat
SYSCONFIG[CXX] g   -pthread -B /home/docs/checkouts/readthedocs.org/user_builds/numba/conda/9675/compiler_compat

Despite having gxx_linux-64 installed, sysconfig is still pointing to /usr/bin/gcc.

@sklam sklam added the skip_release_notes Skip towncrier requirement label Jul 29, 2024
@sklam
Use miniconda on RTD to fix incorrect c-compiler
3eb670f 
- Problem was in mambaforge. Tested version 22.9 as well
@sklam sklam marked this pull request as ready for review July 29, 2024 21:55
gmarkall
gmarkall approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@gmarkall gmarkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge, seeing as it fixes the RTD build. I was expecting an impact on RTD build time, but it seems to be faster than some of the previous passing runs that I can find.

@gmarkall gmarkall added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Jul 30, 2024
@sklam sklam merged commit 99f5cc6 into numba:main Jul 30, 2024
25 checks passed
This was referenced Jul 31, 2024
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarkall gmarkall gmarkall approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge doc Effort - short Short size effort needed skip_release_notes Skip towncrier requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sklam @gmarkall