Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set annotation as empty in OverloadFunctionTemplate #9572

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

set annotation as empty in OverloadFunctionTemplate #9572

wants to merge 3 commits into from

Conversation

dlee992
Copy link
Contributor

@dlee992 dlee992 commented May 13, 2024 •
edited
Loading

fixes #9571

gentle tag @guilhermeleobas

Note for reviewers:

  • does numba want to leverage python type hints? or have used somewhere?
  • I assume numba doesn't care about type hints (i.e., annotation), so I just set it as empty for all parameters.

@dlee992
Copy link
Contributor Author

dlee992 commented Sep 19, 2024

I think this can be added into next release rc?

@guilhermeleobas
Copy link
Contributor

Hi @dlee992, sorry for the delay in reviewing this. Unfortunately, I don't have the bandwidth to review it at the moment.

@dlee992
Copy link
Contributor Author

dlee992 commented Sep 23, 2024

HA, don't worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam Awaiting requested review from sklam

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3 - Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different type hints will result in TypingError when using overload
2 participants
@dlee992 @guilhermeleobas