Add relative working directory to NerdbankGitVersioning attribute #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for mono repos by allowing usage of different configuration files in subdirectories.
Sam13
force-pushed
the
feature/nbgv-attribute-working-dir
branch
from
c2ffc94
to
0c13515
Compare
|
@matkoch I don't think I'm responsible for all those Quodana errors during PR build :-| |
matkoch
reviewed
Jul 25, 2023
| public override object GetValue(MemberInfo member, object instance) | ||
| { | ||
| var version = NerdbankGitVersioningTasks.NerdbankGitVersioningGetVersion(s => s | ||
| .DisableProcessLogOutput() | ||
| .SetFormat(NerdbankGitVersioningFormat.json)) | ||
| .SetFormat(NerdbankGitVersioningFormat.json) | ||
| .When(WorkingDirectoryRelativePath != null, x => x.SetProcessWorkingDirectory(Build.RootDirectory / WorkingDirectoryRelativePath))) |
There was a problem hiding this comment.
My intention is to fallback to default working directory determination of ProcessTasks.StartProcess when not providing a relative configuration file directory via the attribute
matkoch
force-pushed
the
develop
branch
3 times, most recently
from
0686f32
to
d6aab06
Compare
matkoch
force-pushed
the
develop
branch
5 times, most recently
from
0231425
to
d806295
Compare
matkoch
force-pushed
the
develop
branch
3 times, most recently
from
7066bbe
to
985de83
Compare
matkoch
force-pushed
the
develop
branch
4 times, most recently
from
0719711
to
6fe1e3b
Compare
matkoch
force-pushed
the
develop
branch
2 times, most recently
from
6d02194
to
4bfee84
Compare
matkoch
force-pushed
the
develop
branch
3 times, most recently
from
1ac5d51
to
85998da
Compare
matkoch
force-pushed
the
develop
branch
4 times, most recently
from
e652c9a
to
6ed9e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for mono repos by allowing usage of different configuration files in subdirectories.
See https://github.com/dotnet/Nerdbank.GitVersioning/blob/main/doc/pathFilters.md for documentation about multiple NBGV configuration files in same repository.
Usage:
I confirm that the pull-request: