Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSCP Selector dropdown no longer renders while viewing active flows #8624

Closed
RobertTheProfessional opened this issue Aug 14, 2024 · 2 comments
Closed

DSCP Selector dropdown no longer renders while viewing active flows #8624

RobertTheProfessional opened this issue Aug 14, 2024 · 2 comments
Assignees
@MatteoBiscosi
Labels
Ready to Test a feedback is needed on a proposal or implementation

Comments

@RobertTheProfessional
Copy link

Environment:

  • OS name: opnsense
  • OS version: FreeBSD 14.1
  • Architecture: amd64
  • ntopng version/revision: v.6.3.240813

What happened:

After upgrading from ntopng 6.0 Community, the DSCP Selector dropdown no longer renders while viewing active flows. Yet, when an integer value for a DSCP tag (CS4==32 or CS5==40) is provided as a query parameter in the URL as such https://ntopng/lua/flows_stats.lua?flowhosts_type=&...&dscp=32, the flows are correctly filtered by their DSCP value similar to ntopng 6.0 behavior.

How did you reproduce it?

ntopng/scripts/lua/flows_stats.lua

Lines 190 to 192 in 9a35ae5

if (dscp_filter ~= nil) then
page_params["dscp"] = dscp_filter
end

ntopng/scripts/lua/flows_stats.lua

Line 293 in 9a35ae5

printActiveFlowsDropdown(base_url, page_params, ifstats, flowstats)

ntopng/scripts/lua/modules/flow_utils.lua

Lines 2474 to 2482 in 9a35ae5

-- DSCP selector
-- table.clone needed to modify some parameters while keeping the original unchanged
local dscp_params = table.clone(page_params)
dscp_params["dscp"] = nil
print [[, '<div class="btn-group float-right">]]
printDSCPDropdown(base_url, dscp_params, flowstats["dscps"] or {}, format_utils)
print [[</div>']]

Debug Information:

image
MatteoBiscosi added a commit that referenced this issue Aug 14, 2024
@MatteoBiscosi
Re-added dscp flow filter (#8624)
8e614ec
@MatteoBiscosi
Copy link
Member

the issue should now be fixed, in a couple of hours update and let me know

@MatteoBiscosi MatteoBiscosi self-assigned this Aug 14, 2024
@MatteoBiscosi MatteoBiscosi added the Ready to Test a feedback is needed on a proposal or implementation label Aug 14, 2024
@RobertTheProfessional
Copy link
Author

RobertTheProfessional commented Aug 14, 2024 •
edited
Loading

Just tried out the flow_filter.lua patch. My DSCP tags are reported in the dropdown and able to be filtered again.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatteoBiscosi MatteoBiscosi

Labels
Ready to Test a feedback is needed on a proposal or implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobertTheProfessional @MatteoBiscosi