-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for git forking workflow #141
Labels
feature
New feature or request
Comments
Hi there @tschaffter ! I am looking into a way to implement this feature, but I am not sure how soon this will happen! If in the meantime you want to try implementing it, let me know and I can help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use the git forking workflow and each developer open PRs against the upstream repo from their fork.
It seems from the code of
nrwl/nx-set-shas@v4
that the main branch of the fork is used to compute the Base SHA, not the main branch of upstream. The code seems to systematically useorigin/${mainBranchName}
. In the context of a PR opened from a fork that target the upstream repo,origin
refers to the remote of the fork.Is there a way with the current implementation to have the Base SHA calculated using the actual target remote (e.g.
upstream
)?If not, one solution would be to allow the user of the action to specify the remote too, in a similar way the action
actions/checkout@v4
allows us to do so.The text was updated successfully, but these errors were encountered: