feat(core): support compile to wasi target #22870
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dcac42e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
After spending several hours reviewing the source code of |
|
Failed to publish a PR release of this pull request, triggered by @FrozenPandaz. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-22870-1e85c39
To request a new release for this pull request, mention someone from the Nx team or the |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-22870-dcac42e
To request a new release for this pull request, mention someone from the Nx team or the |
FrozenPandaz
requested review from
FrozenPandaz,
vsavkin,
a team,
AgentEnder,
jaysoo and
JamesHenry
as code owners
There was a problem hiding this comment.
Thank you so much @Brooooooklyn! Did a lot of refining here and it's working well!
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This pull request is trying to add wasm32-wasi target support for the nx/native
To test the build, you can run the following commands:
rustup target add wasm32-wasip1-threadspnpm exec napi build --release --platform --package-json-path packages/nx/package.json --manifest-path packages/nx/Cargo.toml --js ./native-bindings.js -o packages/nx/src/native --target wasm32-wasip1-threadsAnd the wasm file will be built at packages/nx/src/native/nx.wasm32-wasi.wasm
Blocked by:
wasm32-wasi-preview1-threadswas renamed napi-rs/napi-rs#2009The pseudo_terminal mod is excluded on the wasm32 targets, which is as expected.
The watch mod is excluded because of the upstream
watchexecdeps introduced by ignore-files don't support the wasi target at this moment (but we can improve it).Related Issues
Fixes #21860
Fixes #23821