This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
cli: shinier update-notifier #20122
Closed
cli: shinier update-notifier #20122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
release-next
branch
3 times, most recently
from
bcc4670
to
4a65b3b
Compare
zkat
force-pushed
the
zkat/shiny-notifier
branch
3 times, most recently
from
719cb2e
to
001fd3d
Compare
This message is based on the one pnpm uses, which I think takes care of all the false update messages and missing -g that happens with the default notifier message. It also tells people what "level" the update is.
zkat
force-pushed
the
zkat/shiny-notifier
branch
from
001fd3d
to
4205b5c
Compare
iarna
approved these changes
Apr 9, 2018
iarna
force-pushed
the
release-next
branch
3 times, most recently
from
2e76172
to
fe31e66
Compare
iarna
force-pushed
the
release-next
branch
2 times, most recently
from
63c9452
to
1b021d0
Compare
|
Landed in 6.0.0! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message is based on the one pnpm uses, which
I think takes care of all the false update messages and
missing -g that happens with the default notifier message.
Preview:
I did 4 things:
npm.load()so we have access to config. I think this is fine -- if your npm isn't even loading, you can't even update, so.-gin the message becauseupdate-notifier's detection of globals keeps messing up and if people have npm installed locally, they probably know well enough that they need to omit the -g -- vs folks getting confused because the-gis missing.Cheers to @zkochan for the corresponding version of this in
pnpm, which I think is way better than the default, and I hope he's ok with us cribbing it like this. 💚