Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] copy button hiding text #19

Closed
sachinraja opened this issue Jun 22, 2021 · 8 comments
Closed

[BUG] copy button hiding text #19

sachinraja opened this issue Jun 22, 2021 · 8 comments

Comments

@sachinraja
Copy link

sachinraja commented Jun 22, 2021

What / Why

The text at the end of each code block is cut off by the copy button.
image
image from here

The full line is http.createServer(...).listen(process.env.npm_package_config_port), but the reader can only see http.createServer(...).listen(process.env.npm_package_config.

Where

  • any block where the text fills the entire line

How

Current Behavior

  • copy button covers last part of line in code block

Steps to Reproduce

  • go to any block where the text fills the entire line on the documentation website

Expected Behavior

  • the copy button should not hide any text or should only show on hover (this is what GitHub does)
@MylesBorins
Copy link
Contributor

hey @sachinraja thanks for reporting. It might take our team a couple weeks to find time to work on this. I'm throwing a help wanted label on here in the mean time in case anyone wants to try and fix this

@sachinraja sachinraja changed the title [BUG] Only show the copy button on hover [BUG] copy button hiding text Jun 25, 2021
@khairnarsaurabh23
Copy link

@MylesBorins i want to work on this issue?

@khairnarsaurabh23
Copy link

It will be greate if i'll get some resourses for reference?

@MylesBorins
Copy link
Contributor

hey @khairnarsaurabh23 I just noticed that it appears @sachinraja might have fixed this in npm/doctornpm#1 (and we totally missed it). Will give that a review this week and let you know if that closes this issue

MylesBorins added a commit that referenced this issue Jul 26, 2022
* documentation for --auth-type=web
* documentation for twitter   github link
@sanmins
Copy link

sanmins commented Oct 12, 2022

[BUG] copy button hiding text

1 similar comment
@sanmins
Copy link

sanmins commented Oct 12, 2022

[BUG] copy button hiding text

@sanmins
Copy link

sanmins commented Oct 12, 2022

yy

@AshwanthramKL
Copy link

Hey this still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants