Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Redirect URL's placeholder in workflow gets encoded when notification is sent #6040

Closed
2 tasks done
samya-ak opened this issue Jul 11, 2024 · 1 comment
Closed
2 tasks done
Labels

Comments

@samya-ak
Copy link

samya-ak commented Jul 11, 2024

📜 Description

If the Redirect URL has placeholder for query parameters, query parameters placed in placeholder is encoded.
eg:
In this URL http://localhost:3000/projects/{{projectId}}/schedule?{{filters}}&something=something, query parameters placed in filters placeholder is encoded and. Albeit, &something=something remains as it is.

http://localhost:3000/projects/28800f71/schedule?scheduleType=DETAIL turns into
http://localhost:3000/projects/28800f71/schedule?scheduleType=DETAIL

👟 Reproduction steps

  1. Create a workflow with Redirect URL that has placeholder for query parameters
    image

In above picture, filters placeholder may have multiple query parameters eg: scheduleType=DETAIL&projectType=PAID

  1. Send notification using above workflow with redirect URL

👍 Expected behavior

Placeholders in Redirect URL should not be encoded

👎 Actual Behavior with Screenshots

Placeholders in Redirect URL are encoded

Novu version

0.24.0

npm version

No response

node version

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

@samya-ak samya-ak changed the title 🐛 Bug Report: Redirect URL in workflow gets encoded when notification is sent 🐛 Bug Report: Redirect URL's placeholder in workflow gets encoded when notification is sent Jul 11, 2024
@SokratisVidros SokratisVidros closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants