Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use payload as string instead of map #6

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erikcardona
Copy link

Reason:
I had issue from my project because of the version of poison dependency.

Solution:
Reduce dependency removing poison and change payload from map to string.

@erikcardona
Copy link
Author

@burntcarrot

@burntcarrot
Copy link
Member

@erikcardona Could you please fix the CI issues?

@erikcardona
Copy link
Author

@burntcarrot it should be fine now

@burntcarrot
Copy link
Member

I thought about this decision, but I feel it would be a huge deal-breaker for someone who would be using the library, as moving payload to a string essentially renders the ease of use provided by this library obsolete. Having to encode the payload manually through escape characters is a cumbersome task, as it gets harder when the payload is large, and you need to manually add escape characters each time.

I do understand the conflicts brought by poison, but having the payload as a string, at least for now, doesn't seem like a right option.

Could you rethink the design? I'm refactoring some code to make the user experience much better in #7, if that interests you, please take a look. (spoiler: it still uses poison 5.0.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants