ebb: Poll the button to pause/resume the plot #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After sending every point to the plotter, query the status of the physical button and pause if the operator has pressed it. If so, busy poll for it to be released and pressed again to resume the plot. Also report the EBB firmware version on startup.
|
Maybe calling firmware version in the constructor is breaking the test due to the serial port mocking? I'll try moving it to the |
|
Guess that was it. I can squash these into one commit if you prefer. |
|
Closes #179 @osresearch Mind opening this against https://github.com/alexrudd2/saxi? |
alexrudd2
reviewed
Nov 7, 2024
| @@ -108,6 108,11 @@ export class EBB { | |||
| } | |||
| } | |||
|
|
|||
| /** Send the new General Query command to get limit switch, button and fifo status */ | |||
| public async queryGeneral(): Promise<number> { | |||
| return parseInt(await this.query("QG"), 16); | |||
There was a problem hiding this comment.
If I'm understanding correctly, this is only available in the 3.0 firmware, right?
If so, this should probably check the firmware version first:
Line 23 in 31f59ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sending every point to the plotter, query the status of the physical button and pause if the operator has pressed it. If so, busy poll for it to be released and pressed again to resume the plot.
Also report the EBB firmware version on startup.