Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thirdparty.py for support kubernetes_asyncio. #809

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

caffeinism
Copy link

The model of the official sdk of kubernetes and the model of kubernetes_asyncio work the same. So we can support the model in the same way.

closes: #806

@caffeinism caffeinism requested a review from nolar as a code owner July 26, 2021 08:02
The model of the official sdk of kubernetes and the model of kubernetes_asyncio work the same.

Signed-off-by: Kim Minjong <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2021

This pull request introduces 1 alert when merging 248ef78 into 308e7ff - view on LGTM.com

new alerts:

  • 1 for Unused import

@TahreemSaleem
Copy link

Hi, is there any timeline on when this change will be merged?

I had to use the V1Secret object from official k8s python client instead of the object provided by kubernetes_asyncio since the adopt function cannot accept the kubernetes_asyncio object(s)

@caffeinism caffeinism closed this May 26, 2022
@m3talstorm
Copy link

We also need this feature

@tsyganov-ivan
Copy link

Sorry, but why this MR was closed?
Supports of kubernetes_asyncio looks really important in async k8s operator.

@nolar
Copy link
Owner

nolar commented Oct 24, 2023

Let’s keep it open so that it remains in my attention.

The nearest release is expected to happen with Python 3.12 support once the last blocker (iohttp) is released: #1067; plus all easy prs combined (and retested) in a single batch.

@nolar nolar reopened this Oct 24, 2023
V1ObjectMeta = V1OwnerReference = None

try:
from kubernetes_asyncio.client import V1ObjectMeta as V1ObjectMeta, V1OwnerReference as V1OwnerReference

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'V1OwnerReference' is not used.

try:
from kubernetes_asyncio.client import V1ObjectMeta as V1ObjectMeta, V1OwnerReference as V1OwnerReference
except ImportError:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thirdparty support for kubernetes_asyncio?
5 participants