Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-addon-api
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.1.0
Choose a base ref
...
head repository: nodejs/node-addon-api
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.2.0
Choose a head ref
  • 11 commits
  • 38 files changed
  • 6 contributors

Commits on Sep 3, 2021

  1. test: fixed the way to enable C exceptions. (#1061)

    PR-URL: #1061
    Reviewed-By: Michael Dawson <[email protected]>
    NickNaso authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    b2f8619 View commit details
    Browse the repository at this point in the history
  2. doc: fix documentation about how to enable C exception (#1059)

    * doc: fixed doc about how to enable C   exceptions.
    
    PR-URL: #1059
    Reviewed-By: Michael Dawson <[email protected]>
    NickNaso authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    9aaf3b1 View commit details
    Browse the repository at this point in the history
  3. test: fix errors reported by newer compiler

    - fix error reported about possible use of
      un-initialized variable from newer compiler
    
    Signed-off-by: Michael Dawson <[email protected]>
    mhdawson committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    da2e754 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. src,test: allow creating Function with move-only functor

    Function::New fails to compile when given a move-only functor. For
    example, when constructing a callback function for Promise#then, a
    lambda might capture an ObjectReference. Creating a Function for such a
    lambda results in a compilation error.
    
    Tweak Function::New to work with move-only functors.
    
    For existing users of Function::New, this commit should not change
    behavior.
    strager committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    3e5897a View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. test: standardize unit test file names

    - change all unit test file names to snake case
      this helps in parsing file names to tokens and infer metadata
      like export initializers
    
    - all other changes other than file names is due to linter errors
    
    PR-URL: #1056
    Reviewed-By: Michael Dawson <[email protected]
    Reviewed-By: NickNaso <[email protected]>
    Deepak Rajamohan authored and mhdawson committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    cbac3aa View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. test: run tests with opts to prefix bld root path

    PR-URL: #1055
    Reviewed-By: Michael Dawson <[email protected]>
    Deepak Rajamohan authored and mhdawson committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    62b666c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    22a2f3c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. docs: fix typos (#1068)

    todoroff authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    76de4d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. src: fix casts to not be undefined behavior

    I guess if these were broken in practice, V8/Node.js itself would also
    experience difficulties with it, but there’s no real reason not to use
    the proper alternatives.
    
    PR-URL: #1070
    Reviewed-By: Michael Dawson <[email protected]>
    addaleax authored and mhdawson committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    2b57a4a View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Merge pull request #1065 from strager/move-only-functor

    src,test: allow creating Function with move-only functor
    NickNaso authored Sep 17, 2021
    Configuration menu
    Copy the full SHA
    2dc1f5b View commit details
    Browse the repository at this point in the history
  2. Prepare release v4.2.0.

    NickNaso committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    79d5651 View commit details
    Browse the repository at this point in the history
Loading