Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-addon-api
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.0.0
Choose a base ref
...
head repository: nodejs/node-addon-api
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.1.0
Choose a head ref
  • 9 commits
  • 48 files changed
  • 6 contributors

Commits on Jun 18, 2021

  1. src: set default return value of Reference Ref/Unref to 0

    PR-URL: #1004
    Reviewed-By: Michael Dawson <[email protected]>
    legendecas authored and mhdawson committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    37a9b8e View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. doc: update examples for context sensitivity

    Fixes: #1011
    
    PR-URL: #1013
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    KevinEady authored and mhdawson committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    627dbf3 View commit details
    Browse the repository at this point in the history
  2. test: dd check for nullptr inside String init

    PR-URL: #1015
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Kevin Eady <[email protected]>
    JckXia authored and mhdawson committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    da50b51 View commit details
    Browse the repository at this point in the history
  3. test: add first set of symbol tests

    PR-URL: #972
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Nicola Del Gobbo <[email protected]>
    JckXia authored and mhdawson committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    e02e8a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. src,test: fix up null char * exception thrown

    Throw an exception when receiving a null pointer for the `char *` and
    `char16_t *` overloads of `String::New` that looks identical to an
    error that core would have thrown under the circumstances
    (`napi_invalid_arg`).
    
    Also, rename the test methods to conform with our naming convention.
    
    PR-URL: #1019
    Reviewed-By: Nicola Del Gobbo <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    gabrielschulhof committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    6697c51 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. doc: update tests to avoid running in parallel

    fixes: #1022
    
    The objectwrap_worker_thread and symbol tests
    were not waiting for the test to complete before the
    subsequent tests were started. This caused intermitted
    crashes in the CI.
    
    Updated both tests so that they complete before the
    next test runs.
    
    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #1024
    Reviewed-By: Chengzhong Wu <[email protected]>
    mhdawson committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a459f5c View commit details
    Browse the repository at this point in the history
  2. src: add AddCleanupHook

    Add CleanupHook support to Env
    
    PR-URL: #1014
    Reviewed-By: Michael Dawson <[email protected]>
    KevinEady authored and mhdawson committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    10564a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. src: return Maybe on pending exception when cpp exception disabled

    PR-URL: #927
    Reviewed-By: Michael Dawson <[email protected]>
    legendecas authored Aug 3, 2021
    Configuration menu
    Copy the full SHA
    3615041 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Prepare release 4.1.0.

    NickNaso committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4a3de56 View commit details
    Browse the repository at this point in the history
Loading